Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest an appropriate module name with the 'defprotocol' snippet #715

Merged
merged 1 commit into from
Oct 3, 2022

Conversation

oo6
Copy link
Contributor

@oo6 oo6 commented Aug 4, 2022

No description provided.

@oo6 oo6 changed the title Suggest an appropriate module name with the 'defprotocol' and 'defimpl' snippet Suggest an appropriate module name with the 'defprotocol' snippet Aug 10, 2022
@lukaszsamson
Copy link
Collaborator

@oo6 please look into failing tests

@oo6 oo6 closed this Aug 15, 2022
@oo6 oo6 deleted the snippet branch August 15, 2022 02:46
@oo6 oo6 restored the snippet branch August 15, 2022 02:46
@oo6 oo6 reopened this Aug 15, 2022
@oo6 oo6 force-pushed the snippet branch 2 times, most recently from 8116b90 to 1ebc2dc Compare August 15, 2022 03:21
@oo6
Copy link
Contributor Author

oo6 commented Aug 15, 2022

@oo6 please look into failing tests

fixed

@lukaszsamson
Copy link
Collaborator

@oo6 Can you resolve merge conflicts?

@oo6 oo6 force-pushed the snippet branch 3 times, most recently from db7b6fc to 37746e1 Compare October 3, 2022 02:14
@oo6
Copy link
Contributor Author

oo6 commented Oct 3, 2022

@oo6 Can you resolve merge conflicts?

Done.
By the way, the test failure doesn't seem to be related to my changes.

@lukaszsamson
Copy link
Collaborator

Thanks

@lukaszsamson lukaszsamson merged commit 866601e into elixir-lsp:master Oct 3, 2022
@oo6 oo6 deleted the snippet branch January 12, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants